fix(codegen): swap ser/de generation for event streams#2072
Open
battledash wants to merge 1 commit into
Open
Conversation
battledash
changed the title
Author
|
I thought about this again and realized the current behavior is only incorrect for servers, but this when calling I'm just going to handle events outside of smithy for now lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Maybe I'm just missing something here, but serialization generation for event streams is backwards? It generates a serializer for input streams and a deserializer for output streams. The generated code doesn't compile because the wrong function exists:
[build:types] src/protocols/Aws_restJson1.ts(62,21): error TS2552: Cannot find name 'de_ServerInputStream'. Did you mean 'se_ServerInputStream'?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.